Major rework on SerialDevice and Engine#152
Merged
josesimoes merged 1 commit intonanoframework:developfrom Jun 18, 2018
Merged
Conversation
Member
|
Hi @josesimoes, I'm nanoFramework bot. A human will be reviewing it shortly. 😉 |
- Partial rewrite on the connect device workflow - Improvements on the disconnect device worfflow - SerialPort now has Read and Send cancellation tokens to improve cancelling of pending I/O operations on device disconnect - Valid nanoDevice checking after complete devices enumeration is now carried as a separate task and not part of handler anymore - Remove unused flag for autoreconnect on serial device event handler - DebugEngine propery in NanoDeviceBase doesn't auto-instanciate anymore - NanoDeviceBase now has a CreateDebugEngine - Engine doesn't offer a Disconnect method anymore - Engine doesn's start background processor on constructor anymore becuase the associated nanoDevice might not be connected at that point, instead is started an ConnectAsync if needed - Engine.RebootDevice doesn't force device disconnection anymore, there are devices that do not require that and even behave oddly if this is forced - Clean up code and remove several debug output messages - Update WPF test app Signed-off-by: José Simões <jose.simoes@eclo.solutions>
86a516e to
3bbad0f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
Screenshots
Types of changes
Checklist:
Signed-off-by: José Simões jose.simoes@eclo.solutions