Skip to content

Fix FlashSectorData ToString#181

Merged
josesimoes merged 2 commits intonanoframework:developfrom
Eclo:fix-flash-map-ouput
Feb 8, 2019
Merged

Fix FlashSectorData ToString#181
josesimoes merged 2 commits intonanoframework:developfrom
Eclo:fix-flash-map-ouput

Conversation

@josesimoes
Copy link
Copy Markdown
Member

Description

  • Improve error messages for memory and flash maps.

Motivation and Context

  • Was throwing an hidden exception when trying to output line for nanoBooter on targets that don't have it.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

- Was throwing an exception when trying to output line for nanoBooter on targets that don't have it.
- Improve error messages for memory and flash maps.

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@nfbot
Copy link
Copy Markdown
Member

nfbot commented Feb 8, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 6b3a44a into nanoframework:develop Feb 8, 2019
@josesimoes josesimoes deleted the fix-flash-map-ouput branch February 8, 2019 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants