Skip to content

Fix progress output on DeploymentExecuteIncremental#192

Merged
josesimoes merged 1 commit intonanoframework:developfrom
Eclo:josesimoes-patch-1
Mar 15, 2019
Merged

Fix progress output on DeploymentExecuteIncremental#192
josesimoes merged 1 commit intonanoframework:developfrom
Eclo:josesimoes-patch-1

Conversation

@josesimoes
Copy link
Copy Markdown
Member

Description

  • Change progress output on foreach iteration.
  • Moved progress output after the foreach on completion.

Motivation and Context

  • The progress report output was wrong as it was repeatedly writing what was supposed to be outputted after the operation completed.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

@nfbot
Copy link
Copy Markdown
Member

nfbot commented Mar 15, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit ad4c47a into nanoframework:develop Mar 15, 2019
@josesimoes josesimoes deleted the josesimoes-patch-1 branch March 15, 2019 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants