Skip to content

Improvements in deployment#205

Merged
josesimoes merged 1 commit intodevelopfrom
improvements-deployment
Jul 23, 2019
Merged

Improvements in deployment#205
josesimoes merged 1 commit intodevelopfrom
improvements-deployment

Conversation

@josesimoes
Copy link
Copy Markdown
Member

Description

  • IsConnected flag is now updated on Ping.
  • IsConnected flag is now lowered on RebootDevice only when appropriate.

Motivation and Context

  • Resolves connection and reconnection issues that showed after increasing the WP baud rate.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

- IsConnected flag is now updated on Ping.
- IsConnected flag is now lowered on RebootDevice only when appropriate.

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@nfbot
Copy link
Copy Markdown
Member

nfbot commented Jul 23, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 8ef3d23 into develop Jul 23, 2019
@josesimoes josesimoes deleted the improvements-deployment branch July 23, 2019 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants