Skip to content

Rework SerialDevice watcher#209

Merged
josesimoes merged 1 commit intonanoframework:developfrom
Eclo:rework-serialdevice-watcher
Sep 10, 2019
Merged

Rework SerialDevice watcher#209
josesimoes merged 1 commit intonanoframework:developfrom
Eclo:rework-serialdevice-watcher

Conversation

@josesimoes
Copy link
Copy Markdown
Member

Description

  • Remove event handler for SerialDevice.
  • Add SerialDeviceManager to decouple the device watcher from the actual SerialDevice.
  • Rework code to have an individual SerialDevice for each connected device instead of reusing the watcher "current device".
  • Rework nano device detection algorithm.
  • Rework workflow of new device added and enumeration completed.
  • Rename Parent to ConnectedPort on nano device for clarity.

*** USB device hasn't been reworked ***

Motivation and Context

  • Improve device detection, removal and adding.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

@nfbot
Copy link
Copy Markdown
Member

nfbot commented Sep 10, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

- Remove event handler for SerialDevice.
- Add SerialDeviceManager to decouple the device watcher from the actual SerialDevice.
- Rework code to have an individual SerialDevice for each connected device instead of reusing the watcher "current device".
- Rework nano device detection algorithm.
- Rework workflow of new device added and enumeration completed.
- Rename Parent to ConnectedPort on nano device for clarity.

*** USB device hasn't been reworked ***

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes force-pushed the rework-serialdevice-watcher branch from 05a0e0f to 17beb26 Compare September 10, 2019 22:18
@josesimoes
Copy link
Copy Markdown
Member Author

SonarCloud failing on low code coverage. Ignoring.

@josesimoes josesimoes merged commit be91074 into nanoframework:develop Sep 10, 2019
@josesimoes josesimoes deleted the rework-serialdevice-watcher branch September 10, 2019 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants