Rework SerialDevice watcher#209
Merged
josesimoes merged 1 commit intonanoframework:developfrom Sep 10, 2019
Merged
Conversation
Member
|
Hi @josesimoes, I'm nanoFramework bot. A human will be reviewing it shortly. 😉 |
- Remove event handler for SerialDevice. - Add SerialDeviceManager to decouple the device watcher from the actual SerialDevice. - Rework code to have an individual SerialDevice for each connected device instead of reusing the watcher "current device". - Rework nano device detection algorithm. - Rework workflow of new device added and enumeration completed. - Rename Parent to ConnectedPort on nano device for clarity. *** USB device hasn't been reworked *** Signed-off-by: José Simões <jose.simoes@eclo.solutions>
05a0e0f to
17beb26
Compare
Member
Author
|
SonarCloud failing on low code coverage. Ignoring. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
*** USB device hasn't been reworked ***
Motivation and Context
How Has This Been Tested?
Screenshots
Types of changes
Checklist:
Signed-off-by: José Simões jose.simoes@eclo.solutions