Skip to content

Major code refactoring#217

Merged
josesimoes merged 1 commit intonanoframework:developfrom
Eclo:code-refactoring
Feb 26, 2020
Merged

Major code refactoring#217
josesimoes merged 1 commit intonanoframework:developfrom
Eclo:code-refactoring

Conversation

@josesimoes
Copy link
Copy Markdown
Member

@josesimoes josesimoes commented Feb 26, 2020

Description

  • Code refactoring to slash unacceptable number of warning from Roslyn and SonarCloud.
  • Bump version to 1.8.1-preview.

Motivation and Context

  • Improve code quality

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: josesimoes jose.simoes@eclo.solutions

@nfbot
Copy link
Copy Markdown
Member

nfbot commented Feb 26, 2020

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes force-pushed the code-refactoring branch 2 times, most recently from 6f20e91 to 3206d85 Compare February 26, 2020 13:07
- Bump version to 1.8.1-preview

Signed-off-by: josesimoes <jose.simoes@eclo.solutions>
@sonarqubecloud
Copy link
Copy Markdown

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
50.9% 50.9% Duplication

@josesimoes
Copy link
Copy Markdown
Member Author

Ignoring code duplication reported by SonarClould.

@josesimoes josesimoes merged commit 33c5fc9 into nanoframework:develop Feb 26, 2020
@josesimoes josesimoes deleted the code-refactoring branch February 26, 2020 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants