Skip to content

Replace several throws with return value#232

Merged
josesimoes merged 1 commit intonanoframework:developfrom
Eclo:remove-throw
Mar 11, 2020
Merged

Replace several throws with return value#232
josesimoes merged 1 commit intonanoframework:developfrom
Eclo:remove-throw

Conversation

@josesimoes
Copy link
Copy Markdown
Member

@josesimoes josesimoes commented Mar 11, 2020

Description

  • Set default value for Engine.ThrowOnCommunicationFailure to false.
  • Update several NuGets.
  • Rework test app regarding device execution querying.
  • Bump version to 1.16.0-preview.

Motivation and Context

  • Throwing so many exception was putting a high burden on the callers to trap and deal with those, thus having the potential to cause VS to freeze and exit without warning.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: josesimoes jose.simoes@eclo.solutions

@josesimoes
Replace several throws with return value
084b548 
- Set default value for Engine.ThrowOnCommunicationFailure to false.
- Update several NuGets.
- Rework test app regarding device execution querying.
- Bump version to 1.16.0-preview.

Signed-off-by: josesimoes <jose.simoes@eclo.solutions>
@nfbot
Copy link
Copy Markdown
Member

nfbot commented Mar 11, 2020

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 11, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@josesimoes josesimoes merged commit 16164b8 into nanoframework:develop Mar 11, 2020
@josesimoes josesimoes deleted the remove-throw branch March 11, 2020 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Breaking-Change CI: Publish Release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@josesimoes @nfbot