Skip to content

Fix UpdateDeviceConfiguration not returning#233

Merged
josesimoes merged 1 commit intonanoframework:developfrom
Eclo:fix-update-config-1
Mar 12, 2020
Merged

Fix UpdateDeviceConfiguration not returning#233
josesimoes merged 1 commit intonanoframework:developfrom
Eclo:fix-update-config-1

Conversation

@josesimoes
Copy link
Copy Markdown
Member

Description

  • Add break to while loop otherwise a critical failure in the communication would cause the loop to never exit thus causing the update operation to never return.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: josesimoes jose.simoes@eclo.solutions

Signed-off-by: josesimoes <jose.simoes@eclo.solutions>
@nfbot
Copy link
Copy Markdown
Member

nfbot commented Mar 12, 2020

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@josesimoes josesimoes merged commit d434768 into nanoframework:develop Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants