Skip to content

Improve update device config#236

Merged
josesimoes merged 1 commit intonanoframework:developfrom
Eclo:improve-config-update
Mar 13, 2020
Merged

Improve update device config#236
josesimoes merged 1 commit intonanoframework:developfrom
Eclo:improve-config-update

Conversation

@josesimoes
Copy link
Copy Markdown
Member

Description

  • Add code to retry once on sending the update chunks.

Motivation and Context

  • Takes care of random communication issues without having to perform the complete operation again.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: josesimoes jose.simoes@eclo.solutions

Signed-off-by: josesimoes <jose.simoes@eclo.solutions>
@nfbot
Copy link
Copy Markdown
Member

nfbot commented Mar 13, 2020

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 139e3e3 into nanoframework:develop Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants