Skip to content

Fix return result for WriteMemory and EraseMemory#249

Merged
josesimoes merged 1 commit intonanoframework:developfrom
Eclo:fix-writememory-return
Sep 5, 2020
Merged

Fix return result for WriteMemory and EraseMemory#249
josesimoes merged 1 commit intonanoframework:developfrom
Eclo:fix-writememory-return

Conversation

@josesimoes
Copy link
Copy Markdown
Member

Description

  • Now return an enum instead of an uint.
  • Rework code to properly process reply from device and return correct result to caller.
  • Bump version to 1.18.2-preview

Motivation and Context

  • Return from these methods wasn't being properly constructed and some conditions return wrong results.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nfbot
Copy link
Copy Markdown
Member

nfbot commented Sep 5, 2020

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

- Now return an enum instead of an uint.
- Rework code to properly process reply from device and return correct result to caller.
- Bump version to 1.18.2-preview
@josesimoes josesimoes force-pushed the fix-writememory-return branch from 7391ef4 to 591aed0 Compare September 5, 2020 16:39
@josesimoes josesimoes merged commit fb97fe9 into nanoframework:develop Sep 5, 2020
@josesimoes josesimoes deleted the fix-writememory-return branch September 5, 2020 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants