Skip to content

Improve init state detection#48

Merged
josesimoes merged 4 commits intonanoframework:masterfrom
Eclo:improve-init-state-detection
Sep 28, 2017
Merged

Improve init state detection#48
josesimoes merged 4 commits intonanoframework:masterfrom
Eclo:improve-init-state-detection

Conversation

@josesimoes
Copy link
Copy Markdown
Member

Description

  • Improve detection of device in initialized state
  • Change return type of IsDeviceInInitializeStateAsync() to Task<>
  • Bump NuGet to 0.4.0-preview026

Motivation and Context

  • Fixes error with proper detection of target execution state.

How Has This Been Tested?

Running test debugger test app.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

- remove Disconnect from RebootDeviceAsync()
- add optional parameter to GetDeviceInfoAsync() so the retrieval of the device information can be forced
- remove backing field of NanoFrameworkDeviceInfo.Valid
- bump NuGet package to 0.4.0-preview024

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
- Change return type of `IsDeviceInInitializeStateAsync()` to `Task<>`
- Bump NuGet to 0.4.0-preview026

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@nfbot
Copy link
Copy Markdown
Member

nfbot commented Sep 28, 2017

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 35aa4fb into nanoframework:master Sep 28, 2017
@josesimoes josesimoes deleted the improve-init-state-detection branch September 28, 2017 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants