Skip to content

Rework event handlers for partial classes#60

Merged
josesimoes merged 1 commit intonanoframework:developfrom
Eclo:rework-on-unavailable-api
Oct 23, 2017
Merged

Rework event handlers for partial classes#60
josesimoes merged 1 commit intonanoframework:developfrom
Eclo:rework-on-unavailable-api

Conversation

@josesimoes
Copy link
Copy Markdown
Member

Description

  • Moved methods from shared classes to specific technologies because of unavailable APIs.

Motivation and Context

  • Removes compilation warnings and potential issues with APIs unavailable in both .NET and UWP implementation.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

@nfbot
Copy link
Copy Markdown
Member

nfbot commented Oct 23, 2017

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes force-pushed the rework-on-unavailable-api branch from 381c276 to f461730 Compare October 23, 2017 09:41
- Moved methods from shared classes to specific technologies becuase of unavailable APIs.

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes force-pushed the rework-on-unavailable-api branch from f461730 to cc88f63 Compare October 23, 2017 10:12
@josesimoes josesimoes merged commit 19e5046 into nanoframework:develop Oct 23, 2017
@josesimoes josesimoes deleted the rework-on-unavailable-api branch October 23, 2017 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants