Skip to content

Add ConfigAwait to async calls#61

Merged
josesimoes merged 1 commit intonanoframework:developfrom
Eclo:add-configawait
Oct 23, 2017
Merged

Add ConfigAwait to async calls#61
josesimoes merged 1 commit intonanoframework:developfrom
Eclo:add-configawait

Conversation

@josesimoes
Copy link
Copy Markdown
Member

Description

  • Add ConfigAwait to async calls.
  • Rename ConnectionSource enum to follow project name casing
  • Add Nuget package with ConfigureAwaitChecker analyser

Motivation and Context

  • Following GP on async/await patterns

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

- following GP on async/await patterns
- rename `ConnectionSource` enum to follow project name casing
- add Nuget package with ConfigureAwaitChecker analyser

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@nfbot
Copy link
Copy Markdown
Member

nfbot commented Oct 23, 2017

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 9e8b684 into nanoframework:develop Oct 23, 2017
@josesimoes josesimoes deleted the add-configawait branch October 23, 2017 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants