Work on MessageReassembler#68
Merged
josesimoes merged 1 commit intonanoframework:developfrom Oct 25, 2017
Merged
Conversation
- Refactor `operationTimeout` in `ProcessAsync` to ease reuse on calls bellow - Fix `CompletePayload` code that wasn't forwarding unexpected messages - Fix `ProcessMessage` that wasn't correctly validating the reply when it was originated by a request - Code clean-up - Remove `Debug.WriteLine` as those are not required anymore Signed-off-by: José Simões <jose.simoes@eclo.solutions>
Member
|
Hi @josesimoes, I'm nanoFramework bot. A human will be reviewing it shortly. 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
operationTimeoutinProcessAsyncto ease reuse on calls bellowCompletePayloadcode that wasn't forwarding unexpected messagesProcessMessagethat wasn't correctly validating the reply when it was originated by a requestDebug.WriteLineas those are not required anymoreMotivation and Context
How Has This Been Tested?
Screenshots
Types of changes
Checklist:
Signed-off-by: José Simões jose.simoes@eclo.solutions