Skip to content

Stability improvements#70

Merged
josesimoes merged 1 commit intonanoframework:developfrom
Eclo:stability-improvements
Oct 27, 2017
Merged

Stability improvements#70
josesimoes merged 1 commit intonanoframework:developfrom
Eclo:stability-improvements

Conversation

@josesimoes
Copy link
Copy Markdown
Member

Description

  • Remove call to Start in ConnectAsync because we need to have better control over this
  • Add code to check for invalid Capabilities on ConnectAsync and failing on error
  • Made Engine.Start return Task so it can be properly used as a Task
  • Improve cancellation token management in Engine.Start
  • Rework code to add devices to nanoDevices collection
  • Rework code to ReadBufferAsync in order to prevent throwing exceptions on errors
  • Update WPF test app

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

- Remove call to Start in ConnectAsync because we need to have better control over this
- Add code to check for invalid Capabilities on ConnectAsync and failing on error
- Made Engine.Start  return Task so it can be properly used as a Task
- Improve cancellation token management in Engine.Start
- Rework code to add devices to nanoDevices collection
- Rework code to ReadBufferAsync in order to prevent throwing exceptions on errors
- Update WPF test app

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@nfbot
Copy link
Copy Markdown
Member

nfbot commented Oct 27, 2017

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit dd3bcdb into nanoframework:develop Oct 27, 2017
@josesimoes josesimoes deleted the stability-improvements branch October 27, 2017 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants