Skip to content

Fix GetDeviceInfo#74

Merged
josesimoes merged 1 commit intonanoframework:developfrom
Eclo:fix-get-assemblies
Nov 2, 2017
Merged

Fix GetDeviceInfo#74
josesimoes merged 1 commit intonanoframework:developfrom
Eclo:fix-get-assemblies

Conversation

@josesimoes
Copy link
Copy Markdown
Member

Description

  • Improve workflow of GetAppDomainsAsync and GetAssembliesAsync to catch invalid replies from device

Motivation and Context

  • Fixes issues in getting assemblies from device

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

@nfbot
Copy link
Copy Markdown
Member

nfbot commented Nov 2, 2017

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

- Improve workflow of GetAppDomainsAsync and GetAssembliesAsync to catch invalid replies from device

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes merged commit ab5a944 into nanoframework:develop Nov 2, 2017
@josesimoes josesimoes deleted the fix-get-assemblies branch November 2, 2017 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants