Skip to content

Major rework on fundamental classes#87

Merged
josesimoes merged 1 commit intonanoframework:developfrom
Eclo:major-rework
Nov 29, 2017
Merged

Major rework on fundamental classes#87
josesimoes merged 1 commit intonanoframework:developfrom
Eclo:major-rework

Conversation

@josesimoes
Copy link
Copy Markdown
Member

Description

  • Requests are now performed in truly async fashion with TPL
  • Rename Request to WireProtocolRequest
  • Serious rework on Message reassembler to make it sync
  • Work on Engine:
    • now has a true background message processor listening for messages from the target device
    • clean-up code
    • rework on severak ProcessRequest methods to use new methods
    • has a store to mamange ongoing requests
  • Work on SerialPort to improve device discovery process and throw exception on device disconnected
  • Work on Controller:
    • clean-up code and remove unused stuff
    • add semaphore for sending operations
  • Packet now has a fixed market set at constructor
  • Add request store to handle ongoing Wire Protocol requests
  • Applied coding standards to reworked code files
  • Update WPF test app

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

- Requests are now performed in truly async fashion with TPL
- Rename Request to WireProtocolRequest
- Serious rework on Message reassembler to make it sync
- Work on Engine:
  + now has a true background message processor listening for messages from the target device
  + clean-up code
  + rework on severak ProcessRequest methods to use new methods
  + has a store to mamange ongoing requests
- Work on SerialPort to improve device discovery process and throw exception on device disconnected
- Work on Controller:
  + clean-up code and remove unused stuff
  + add semaphore for sending operations
- Packet now has a fixed market set at constructor
- Add request store to handle ongoing Wire Protocol requests
- Applied coding standards to reworked code files
- Update WPF test app

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@nfbot
Copy link
Copy Markdown
Member

nfbot commented Nov 29, 2017

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit d94f198 into nanoframework:develop Nov 29, 2017
@josesimoes josesimoes deleted the major-rework branch November 29, 2017 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants