Skip to content

Rework async methods for debug engine#98

Merged
josesimoes merged 1 commit intonanoframework:developfrom
Eclo:rework-async-calls
Dec 5, 2017
Merged

Rework async methods for debug engine#98
josesimoes merged 1 commit intonanoframework:developfrom
Eclo:rework-async-calls

Conversation

@josesimoes
Copy link
Copy Markdown
Member

Description

  • Rework async methods for debug engine
  • Rework test apps accordingly

Motivation and Context

  • The use of async methods isn't not compatible with the CorDebug synchronous nature

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

@nfbot
Copy link
Copy Markdown
Member

nfbot commented Dec 5, 2017

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

- Rework test apps accordingly

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes merged commit 70809ea into nanoframework:develop Dec 5, 2017
@josesimoes josesimoes deleted the rework-async-calls branch December 5, 2017 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants