Skip to content

Conversation

@josesimoes
Copy link
Member

Description

  • Add CMake build option ESP32_RESERVED_RAM_FOR_IDF_ALLOCATION.
  • Update CMake and ESP32 target platform accordingly.
  • Update memory allocation define.
  • Update CmakePresets for all PICO and Ethernet targets to reserve 10k of internal RAM.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dev Containers (changes related with Dev Containers, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).

@josesimoes josesimoes added the Platform: ESP32 Everything related specifically with ESP32 platform label Nov 1, 2022
@AdrianSoundy
Copy link
Member

AdrianSoundy commented Nov 2, 2022

The builds are failing because its not finding the default value of ESP32_RESERVED_RAM_FOR_IDF_ALLOCATION (0)
So we get

C:/nanof/nf-interpreter/build/targets/ESP32/ESP32/target_platform.h:13:47: error: 'OFF' was not declared in this scope
[build]  #define ESP32_RESERVED_RAM_FOR_IDF_ALLOCATION OFF

You have
option( ESP32_RESERVED_RAM_FOR_IDF_ALLOCATION "Reserved RAM for IDF allocation (in kBytes)" 0)
in esp32\CmakeLists.txt
So not sure why it's not working

@AdrianSoundy
Copy link
Member

Other than changes above looks good to me,

@josesimoes josesimoes force-pushed the add-idf-memory-build-option branch from 8aa9b83 to 9b7f8b3 Compare November 7, 2022 10:33
@josesimoes josesimoes merged commit addb9dc into main Nov 7, 2022
@josesimoes josesimoes deleted the add-idf-memory-build-option branch November 7, 2022 11:06
aromaa pushed a commit to aromaa/nf-interpreter that referenced this pull request Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Config-and-Build Platform: ESP32 Everything related specifically with ESP32 platform

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants