Skip to content

Conversation

@josesimoes
Copy link
Member

@josesimoes josesimoes commented Oct 9, 2017

Description

  • CRT heap now has defined size (was managed Heap).
  • Update linker and rules files accordingly.

Motivation and Context

  • The previous approach had a defined size for the managed Heap (defined as a linker symbol). The CRT heap was taking the available RAM left from all the other region assignments.
    This approach required an adjustment (increase) of the managed Heap as more features where added to the image. The need for this manual adjustment prevented the automated resize of the available RAM for the managed heap, which is a poor solution.
    Moreover there was an issue with the managed heap definition that was wrongly setting the region start to the RAM start.

How Has This Been Tested?

Image compiled and tested with Blinky on several reference boards.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

@josesimoes josesimoes added Area: Config-and-Build Series: STM32xx Everything related specifically with STM32 targets Type: bug Type: enhancement labels Oct 9, 2017
@nfbot
Copy link
Member

nfbot commented Oct 9, 2017

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes force-pushed the improve-heap-definition branch from 91af619 to cce96e9 Compare October 10, 2017 08:22
- CRT heap now has defined size (was managed Heap)
- update linker and rules files accordingly

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes force-pushed the improve-heap-definition branch from cce96e9 to bec9650 Compare October 12, 2017 07:57
@josesimoes josesimoes merged commit 6500330 into nanoframework:master Oct 12, 2017
@josesimoes josesimoes deleted the improve-heap-definition branch October 12, 2017 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Config-and-Build Series: STM32xx Everything related specifically with STM32 targets Type: enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants