Fixed how some gridutils functions treat the logger#1996
Merged
Conversation
Contributor
Author
|
Also added a few annoying messages to "onlyonce" list |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1996 +/- ##
=======================================
Coverage 70.34% 70.34%
=======================================
Files 109 109
Lines 25652 25652
Branches 4081 4081
=======================================
Hits 18044 18044
Misses 6453 6453
Partials 1155 1155 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
This looks fine. I will merge this if ready. |
Contributor
Author
|
I think it is now (or will be after the checks finish). Still don't fully understand all of the subtleties here, but it is a lot better than before. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the functions for doing gridded fits did not respect the global logger settings. This is better now, although I am still seeing some weird behavior from the clock module.