Merged
Conversation
aarchiba
force-pushed
the
model-validation-alternative
branch
2 times, most recently
from
3680fbe to
e6fe78c
Compare
This was referenced Sep 23, 2019
aarchiba
force-pushed
the
model-validation-alternative
branch
from
bbfb7f5 to
c4b06e8
Compare
Fixes nanograv#449 . Also contains the beginning of a reimplementation of get_model with more careful handling of unusual data.
Note that there is at least one model there where it's unclear what the right models are.
aarchiba
force-pushed
the
model-validation-alternative
branch
from
23e736e to
4109cb9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal here is to make models and par files easier to work with, in particular by giving error messages that are as useful as possible on malformed data. Part of the work is code and documentation cleanup. More needs to be done but this introduces a clearer implementation of the model builder code. If people are happy I'll merge this and continue in another PR.