fix(mappings): add conditional check to DateOfBirth property

[lakshmia28]

Summary by CodeRabbit

• Bug Fixes
  • Improved handling of missing birth dates for players, ensuring that empty values are displayed instead of causing errors or displaying incorrect information.

[coderabbitai]

Walkthrough

The change updates the mapping logic for the Birth property in the PlayerMappingProfile class. The new implementation adds a conditional check to handle cases where the DateOfBirth property is null, formatting the date only if a value exists and returning an empty string otherwise. No public interfaces or exported entity signatures are modified.

Changes

File(s)	Change Summary
src/Dotnet.Samples.AspNetCore.WebApi/Mappings/PlayerMappingProfile.cs	Updated mapping for Birth property to handle nullable DateOfBirth values, returning empty string if null.

Possibly related issues

• Fix null handling for newly nullable columns in Player entity #209: Addresses the need to safely handle nullable DateOfBirth in the PlayerMappingProfile.

Possibly related PRs

• feat(service)!: migrate to AutoMapper for Model mapping #194: Introduces the PlayerMappingProfile class, which is directly modified by this PR to improve null handling for the Birth property.

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)

• We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/Dotnet.Samples.AspNetCore.WebApi/Mappings/PlayerMappingProfile.cs (1)

40-40: LGTM! Good fix for preventing the NullReferenceException.

The change correctly handles null DateOfBirth values by checking with HasValue before formatting the date. This will prevent the NullReferenceException mentioned in the PR title.

Minor suggestion: Add spaces around the lambda arrow and ternary operator for better readability:

-options.MapFrom(source =>source.DateOfBirth.HasValue? $"{source.DateOfBirth:MMMM d, yyyy}":string.Empty)
+options.MapFrom(source => source.DateOfBirth.HasValue ? $"{source.DateOfBirth:MMMM d, yyyy}" : string.Empty)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fec91d2 and 11052b0.

📒 Files selected for processing (1)

• src/Dotnet.Samples.AspNetCore.WebApi/Mappings/PlayerMappingProfile.cs (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Codacy Static Code Analysis

[nanotaboada]

Thanks for the contribution @lakshmia28 ! 🙌

Before we can merge this, could you please update your commit message to follow the Conventional Commits specification?

This helps us keep a clean and consistent project history. A typical format looks like:

<type>(optional scope): <short description>

Example:

fix: add conditional check to Birth mapping

Example (scoped):

fix(mappings): add conditional check to Birth property

[lakshmia28]

@nanotaboada : Changed the commit message

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[nanotaboada]

Hi @lakshmia28 ! Thanks for the update — it looks like the PR title was changed, but the commit message itself remains the same: 11052b0

You might need to amend the commit message or redo it and push again. Let me know if you’d like a hand with that!

[nanotaboada]

Why this won’t throw an exception

• Nullable<T>.ToString behavior
  Calling ToString("format") on a DateTime? under the covers invokes Nullable<T>.ToString(String), which—if HasValue is false—returns "" rather than throwing
  Microsoft Learn

• Interpolation → String.Format
  The C# compiler rewrites $"{expr}" to a String.Format call. When an argument is null, String.Format substitutes String.Empty for that item instead of attempting to call a method on null
  Stack Overflow

• Language specification confirmation
  The official C# documentation states that if an interpolation expression is null, the result is the empty string (String.Empty), with no exception raised
  Microsoft Learn