-
Notifications
You must be signed in to change notification settings - Fork 14
chore(ci): lint commit messages #218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughA new step called "Lint commit messages" was added to the "test" job in the GitHub Actions workflow configuration file Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant GitHub Actions
participant CommitLint Action
participant Test Runner
Developer->>GitHub Actions: Push or PR triggers workflow
GitHub Actions->>CommitLint Action: Run "Lint commit messages" step
CommitLint Action-->>GitHub Actions: Report commit message linting result
GitHub Actions->>Test Runner: If lint passes, run tests and coverage
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #218 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 183 183
Branches 14 14
=========================================
Hits 183 183
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/dotnet.yml (2)
48-50: Pin to a specific patch version
Locking the action to a full semantic version (for example@v6.0.1) helps prevent unintentional breaks when minor/patch releases occur:- uses: wagoid/commitlint-github-action@v6 + uses: wagoid/commitlint-github-action@v6.0.1
48-50: Fail fast by running commitlint before build
Since linting commit messages doesn’t depend on build artifacts, consider moving this step to the start of thebuildjob or extracting it into its ownlint-commitsjob. This will catch formatting errors earlier and avoid wasting CI minutes on full builds.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/dotnet.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Codacy Static Code Analysis
🔇 Additional comments (2)
.github/workflows/dotnet.yml (2)
48-50: Add commitlint step in the test job
The new action integrateswagoid/commitlint-github-action@v6correctly and will enforce commit message conventions before running tests.
48-50: Verify commitlint configuration file
By default, this action looks for a config file (e.g.,.commitlintrc.js) in the repository root. Please ensure you have a commitlint config in place or specify its path using theconfigFileinput.



Summary by CodeRabbit