fix: suppress PASSWORD_REQUIRED error for --provider privy#330
Merged
fix: suppress PASSWORD_REQUIRED error for --provider privy#330
Conversation
When Privy env vars are missing, only show the Privy-specific credentials error instead of also emitting an irrelevant PASSWORD_REQUIRED message. Also adds Privy wallet creation examples to the Create quick-reference in the wallet manager skill docs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
TimNooren
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes for the Privy wallet flow:
Issue 1: Skill docs missing Privy wallet flow
Updated
skills/nansen-wallet-manager/SKILL.md- the Create section now shows both the local password flow and the Privy flow (--provider privy, no password needed, required env vars).Issue 2: Misleading dual-error on
nansen wallet create --provider privyAdded an
isPrivyguard insrc/wallet.jsso when--provider privyis specified, the handler returns before reaching password resolution logic. Prevents the irrelevantPASSWORD_REQUIREDerror from appearing alongside the Privy credentials error.Changeset
Patch changeset added for the CLI fix.
Testing
Added a test confirming only the Privy credentials error appears when Privy env vars are missing (no PASSWORD_REQUIRED).