Prevent Null Object References When Calling DialogResultListener Methods #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance this to be merged? |
mitasovr
added a commit
to TangleInc/react-native-touch-id
that referenced
this pull request
Nov 6, 2019
mitasovr
added a commit
to TangleInc/react-native-touch-id
that referenced
this pull request
Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into a number of fatal errors with this form (e.i issue #151 ):
Attempt to invoke interface method 'void com.rnfingerprint.FingerprintDialog$DialogResultListener.{INSERT_DIALOG_RESULT_LISTENER_INTERFACE_METHOD}' on a null object reference"
Using v4.0.4 but latest version doesn't appear to have any new logic that prevents this problem other than removing a call to DialogResultListener.onError. onAuthenticate and onCancelled are still called, sometimes causing this error.