Clean up button css for homepage and gallery#1026
Merged
Merged
Conversation
TimMonko
added a commit
to TimMonko/docs
that referenced
this pull request
May 20, 2026
This was referenced May 20, 2026
DragaDoncila
approved these changes
May 21, 2026
Contributor
DragaDoncila
left a comment
There was a problem hiding this comment.
Looks great, and the csss is more readable too.
Czaki
approved these changes
May 25, 2026
TimMonko
added a commit
that referenced
this pull request
May 29, 2026
# References During the pilot napari workshops, we observed new users having difficulty in navigating to the download buttons because of their location within the page. Built on #1026. two-dot diff: https://github.com/TimMonko/docs/compare/shared-gallery-button-skin..TimMonko:docs:gallery-links # Description This PR moves the download buttons to the top of the example by completely overriding the gallery insertion buttons and making our own button section which is shoved into the sphinx-gallery ready header. To turn off the sphinx-gallery buttons we use css https://sphinx-gallery.github.io/stable/advanced.html#using-sphinx-gallery-sidebar-components Perhaps this should be upstreamed to sphinx-gallery? It might be easier, but perhaps people aren't trying to have the download buttons be so obvious as we are, due to our drag and drop. Present PR: <img width="708" height="456" alt="image" src="https://github.com/user-attachments/assets/0e776083-3dfa-4539-a9e7-45ed8ac8f91f" /> Original This PR: <img width="720" height="231" alt="image" src="https://github.com/user-attachments/assets/5b0d4bf1-9929-4882-9aa2-43a101562d50" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In working on #1021, this work was made more difficult by our messy css.
This PR cleans up the class names and combines the css.
It also sets up for #1021 (and #1024) to reduce the review diff.
This improves the css for the gallery buttons by actually override text and outline, instead of the almost invisible buttons of before
Note that before we did not style the "alt" homepage button and it was just inheriting from pydata-sphinx-theme. This PR explicitly styles the button to vaguely match what was before, but with a shared outline and text color to not be so intense. This is what I had originally intended for the homepage but got quite
confused by the css.
I added lots of comments as I debugged along what each was for. :)
Main: