-
Notifications
You must be signed in to change notification settings - Fork 44
Remove trailing comma in version switcher json #862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hmm, still not liking the json:
That's the closing brace for 0.6.4. Investigating... |
Something is still not quite right...
|
wtf
|
If you check Lorenzo's PR everyone was switched from tab to spaces is that why |
oh no, that's not it |
the config is reading from the URL |
so it's failing because the deployed JSON is borked |
so I think we gotta just merge to give it a go... 😬 |
Yeah, good catch: Line 84 in aebebd7
So we need to merge this, but should re-think the config maybe? because we will always miss PR that break it, because it will not break the build till after deploy. |
With napari/napari.github.io#432 |
This was a syntax error in json and causing the version switcher to fail
altogether on the deployed site.