Skip to content

Update PySide to >=6.7.1 instead of 6.7#274

Merged
jaimergp merged 1 commit into
napari:mainfrom
jni:pyside-patch-version
Jul 28, 2025
Merged

Update PySide to >=6.7.1 instead of 6.7#274
jaimergp merged 1 commit into
napari:mainfrom
jni:pyside-patch-version

Conversation

@jni
Copy link
Copy Markdown
Member

@jni jni commented Jul 27, 2025 •
edited
Loading

Just in case Peter's suspicions about critical bugs (1) are founded.

For reference, a link to the 6.7.1 changelog is included (2).

Update: Linked by Peter below:

  • comment about 6.7.1 being the first passing version (3)
  • Relevant bugfix in qt.io (4)

@jni
Update PySide to >=6.7.1 instead of 6.7
3e8f798 
Just in case Peter's suspicions about critical bugs[1] are founded.

For reference, a link to the 6.7.1 changelog is included[2].

[1]: https://github.com/napari/packaging/issues/269\#issuecomment-3120654140
[2]: https://code.qt.io/cgit/pyside/pyside-setup.git/tree/doc/changelogs/changes-6.7.1
@jni jni mentioned this pull request Jul 27, 2025
Merged
@psobolewskiPhD
Copy link
Copy Markdown
Member

psobolewskiPhD commented Jul 27, 2025

I think i found it:
napari/napari#5657 (comment)
at one time it looks like 6.7.1 was the first version where tests passed locally for me -- though still not on CI.
And there is also https://bugreports.qt.io/browse/PYSIDE-2675 that was solved in 6.7.1 so yeah I think 6.7.1 is the minimum we want to support.

@jaimergp jaimergp merged commit c90daae into napari:main Jul 28, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaimergp jaimergp jaimergp approved these changes

@psobolewskiPhD psobolewskiPhD psobolewskiPhD approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jni @psobolewskiPhD @jaimergp