Sequencer improvements

[TimGroeneboom]

• improved thread safety while loading / saving sequences
• fixed issue where wrong output pins would get disconnected in AudioOutput of sequencer

[Copilot]

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

[Copilot]

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

system_modules/napsequence/src/sequenceplayer.cpp:395

• The comparison directly on the atomic mTime without using load() may lead to incorrect behavior. Please load the current value of mTime into a local variable before performing comparisons.

if(mTime < 0.0)

[Copilot]

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

[Copilot]

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

[cklosters]

For future reference, you don't have to explicitly load the atomic, the operator is overloaded, no matter what ai tells you.

Unlike most assignment operators, the assignment operators for atomic types do not return a reference to their left-hand arguments. They return a copy of the stored value instead.