Fix: use Random.Shared instead of new Random() per call#21
Merged
Conversation
new Random() without a seed can produce identical sequences when called multiple times within the same system tick. Random.Shared is thread-safe and properly seeded, eliminating any chance of correlated rolls. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RandomIntwas creatingnew Random()on every call, which can produce identical sequences when called multiple times within the same system tickRandom.Shared— thread-safe, properly seeded, and the idiomatic .NET 6+ approachEffect
random_introlls in templates are now guaranteed to be independently random🤖 Generated with Claude Code