Skip to content

feat: add top_k#72

Merged
ym-pett merged 1 commit intonarwhals-dev:mainfrom
raisadz:feat/top_k
Nov 25, 2025
Merged

feat: add top_k#72
ym-pett merged 1 commit intonarwhals-dev:mainfrom
raisadz:feat/top_k

Conversation

@raisadz
Copy link
Contributor

@raisadz raisadz commented Nov 25, 2025

Related issue: #35

Copy link
Collaborator

@ym-pett ym-pett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, this works for me. Ran the top_k_test test locally and played with the code.

thanks @raisadz!

(The code looks pretty slick to me me, had to compare it to other nw implementations to get my head around it, very cool)

@ym-pett ym-pett merged commit 0a14274 into narwhals-dev:main Nov 25, 2025
2 checks passed
@raisadz raisadz deleted the feat/top_k branch December 30, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants