Is your feature request related to a problem? Please describe.
CFS apps should avoid having any implicit (compiler-induced) padding in the message structures. Where items are likely to be spaced due to compiler alignment requirements, an explicit spare byte (or bytes) should be added between them.
Describe the solution you'd like
Specifically, the following structures need some padding updates:
- In
CF_SetParamCmd_t: total size needs to be multiple of uint32 (+2 spare bytes at end)
- In
CF_HkPacket_t: +4 bytes spare between the "counters" (CF_HkCmdCounters_t, 4 bytes in size) and the "channel_hk" (CF_HkChannel_Data_t, which contains uint64 values, and therefore has 8-byte alignment).
- In
CF_HkChannel_Data_t: total size needs to be a multiple of uint64 (+4 more spare bytes at end). This currently has 3 spare bytes, which puts the end at offset 84. This is not a multiple of 8, needs 4 more to make it 88.
Additional context
Will need COSMOS updates, too.
Requester Info
Joseph Hickey, Vantage Systems, Inc.
Is your feature request related to a problem? Please describe.
CFS apps should avoid having any implicit (compiler-induced) padding in the message structures. Where items are likely to be spaced due to compiler alignment requirements, an explicit spare byte (or bytes) should be added between them.
Describe the solution you'd like
Specifically, the following structures need some padding updates:
CF_SetParamCmd_t: total size needs to be multiple of uint32 (+2 spare bytes at end)CF_HkPacket_t: +4 bytes spare between the "counters" (CF_HkCmdCounters_t, 4 bytes in size) and the "channel_hk" (CF_HkChannel_Data_t, which contains uint64 values, and therefore has 8-byte alignment).CF_HkChannel_Data_t: total size needs to be a multiple of uint64 (+4 more spare bytes at end). This currently has 3 spare bytes, which puts the end at offset 84. This is not a multiple of 8, needs 4 more to make it 88.Additional context
Will need COSMOS updates, too.
Requester Info
Joseph Hickey, Vantage Systems, Inc.