Fix #41, no packing of CMD/TLM structs#133
Merged
Conversation
The CMD/TLM structures are application-defined. As such, they should not need to depend on compiler-specific extensions like packing. Note that the definitions (mostly) already included explicit spare bytes where padding was likely to be needed, so the "packed" attribute was largely unnecessary here, only serving to make the definitions NOT compilant with C99.
jphickey
force-pushed
the
fix-41-no-pack-cmd-tlm
branch
from
57b6d69 to
772ad79
Compare
jphickey
added
the
CCB:Ready
astrogeco
approved these changes
Dec 16, 2021
astrogeco
requested review from
a user,
pepepr08 and
skliper
and removed request for
a user
skliper
approved these changes
Dec 17, 2021
pepepr08
approved these changes
Dec 17, 2021
astrogeco
removed
the
CCB:Ready
Contributor
|
CCB:2022-01-05 APPROVED |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CMD/TLM structures are application-defined. As such, they should not need to depend on compiler-specific extensions like packing.
Note that the definitions (mostly) already included explicit spare bytes where padding was likely to be needed, so the "packed" attribute was largely unnecessary here, only serving to make the definitions NOT compilant with C99.
Fixes #41