Fix #129, reject FD packets with segment_metadata flag set#151
Merged
Fix #129, reject FD packets with segment_metadata flag set#151
Conversation
The CF does not currently interpret/use the segment metadata option inside file data PDUs. Packets with this bit set should be rejected.
jphickey
added
the
CCB:Ready
astrogeco
removed
the
CCB:Ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
The CF does not currently interpret/use the segment metadata option inside file data PDUs. Packets with this bit set should
be rejected.
Fixes #129
Testing performed
Build CF and run all tests
Execute test file transfers between two CFE nodes
Expected behavior changes
None, CF does not set this bit on Tx, it should never be set on Rx.
System(s) tested on
Ubuntu 21.10
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.