Fix #110, #149, update identifier names#152
Merged
Conversation
jphickey
force-pushed
the
fix-110-149-more-renames
branch
from
6213a5b to
5855cf0
Compare
jphickey
added
the
CCB:Ready
jphickey
force-pushed
the
fix-110-149-more-renames
branch
from
5855cf0 to
252817b
Compare
jphickey
force-pushed
the
fix-110-149-more-renames
branch
from
252817b to
bc7ee2b
Compare
astrogeco
removed
the
CCB:Ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Renames all remaining identifiers that did not have an appropriate name per the coding standards. Specifically, this is anything
that did not start with CF prefix (#149) and anything that ended with an underscore only (#110).
Fixes #149
Fixes #110
Testing performed
Build and sanity check CF, run all tests
Execute test file transfer between two CFE nodes
Expected behavior changes
None, internal symbol rename only
System(s) tested on
Ubuntu 21.10
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.