Fix #62, make entity ID default to 32 bit#159
Merged
Conversation
Entity IDs should be larger by default for real-world applicability, as this also restricts what CFDP can receive, not just what it sends. Note CFDP will only use the number of bytes required to express the value, so values less than 256 will still only use 1 byte, regardless of this config. This just allows use of larger values.
jphickey
added
the
CCB:Ready
semaldona
approved these changes
Jan 12, 2022
astrogeco
removed
the
CCB:Ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Entity IDs should be larger by default for real-world applicability, as this also restricts what CFDP can receive, not just what it sends. Note CFDP will only use the number of bytes required to express the value, so values less than 256 will
still only use 1 byte, regardless of this config. This just allows use of larger values.
Fixes #62
Testing performed
Build and sanity check CF
Expected behavior changes
Default "out of the box" config should support entity ID values up to 32 bits.
System(s) tested on
Ubuntu 21.10
Additional context
This only affects what CF is capable of handling, if running with small (<256) entity ID values, there is no change to the runtime behavior at all; they will still be 8 bits in practice.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.