Fix #161, disable the engine in CF_CFDP_DisableEngine#162
Merged
Fix #161, disable the engine in CF_CFDP_DisableEngine#162
Conversation
Restores setting a global flag which was mistakenly deleted in a previous cleanup.
jphickey
added
the
CCB:Ready
astrogeco
removed
the
CCB:Ready
Contributor
|
There is a future task #145 to go through the code and change int variables that are just being used as bools to proper bools. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Restores setting a global flag which was mistakenly deleted in a previous cleanup. This also adds a unit test check to confirm the global was set false.
Fixes #161
Testing performed
Build CF and run tests
Expected behavior changes
Engine gets disabled when CF_CFDP_DisableEngine is called
System(s) tested on
Ubuntu 21.10
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.