Fix #125, correct accept/reject counter increments#167
Merged
Conversation
For commands that rely on CF_TsnChanAction(), this is documented as returning a count of the number of transactions affected. Therefore, a return value >0 means that the operation was successful (or at least it matched something), and a return value <=0 means failure. - Fixes a case where the function did not adhere to its documented return - Fixes passing the result to CF_CmdCond() which needs a translation.
jphickey
added
the
CCB:Ready
skliper
approved these changes
Jan 18, 2022
zanzaben
approved these changes
Jan 18, 2022
astrogeco
added
CCB:Approved
and removed
CCB:Ready
Contributor
|
CCB:2022-01-19 APPROVED
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
For commands that rely on CF_TsnChanAction(), this is documented as returning a count of the number of transactions affected. Therefore, a return value >0 means that the operation was successful (or at least it matched something), and a return value <=0 means failure.
Fixes #125
Testing performed
Build and sanity check CF
Expected behavior changes
Correct counters being incremented now
System(s) tested on
Ubuntu 21.10
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.