Fix #58, scrub all printf format codes#170
Merged
Conversation
Contributor
Author
|
General rule of thumb - OSAL status codes should be printed as decimal, CFE status codes should be printed as hex, prefer use of the "long" versions of these types (%ld, %lx ,%lu) as this gets the least risk of value truncation/overflow, and cast the value to the intended type since typedef's may vary from system to system. |
jphickey
force-pushed
the
fix-58-scrub-format-codes
branch
3 times, most recently
from
c2e686b to
ed9c8ee
Compare
jphickey
added
the
CCB:Ready
Use the correct printf format code and typecast for printing various values in log messages and events.
jphickey
force-pushed
the
fix-58-scrub-format-codes
branch
from
ed9c8ee to
a07bf5e
Compare
astrogeco
approved these changes
Jan 18, 2022
astrogeco
removed
the
CCB:Ready
Contributor
|
CCB:2022-01-19 APPROVED
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Use the correct printf format code and typecast for printing various values in log messages and events.
Fixes #58
Testing performed
Build and run tests on RTEMS and 32-bit PowerPC
Expected behavior changes
Build succeeds without warnings or errors
System(s) tested on
RTEMS 4.11.3 on pc686 + QEMU
Yocto/Poky Linux on PPC 7400 + QEMU
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.