Fix #40, update traverse history/write file#174
Merged
Conversation
- rename the function to better indicate what it does - do not discard the part of the output that has EID/TSN/CC information - do not pass the return value of snprintf directly to write(), use strlen() - simplify the code
jphickey
added
the
CCB:Ready
skliper
approved these changes
Jan 18, 2022
astrogeco
added
CCB:Approved
and removed
CCB:Ready
Contributor
|
CCB:2022-01-19 APPROVED |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fixes #40
Testing performed
Build and unit test CF.
Run two instances of CFE+CF, execute transfer in both directions and confirm
Issue CF_WRITE_QUEUE_CC (15) to write the transaction and history queues to the file
Confirm contents of the file are correct.
Expected behavior changes
The file contains the information it is intended to contain, mainly the SEQ/DIR/PEER/CC bits are not omitted. There is also no risk of buffer overruns.
Here is an example file output, after running two transactions between two nodes (one RX, one TX)
System(s) tested on
Ubuntu 21.10
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.