Fix #178, remove throttle sem from default/example config#180
Merged
Fix #178, remove throttle sem from default/example config#180
Conversation
Unless something actually instantiates this semaphore, this prevents CF from initializing correctly. With this, at least CF should start up with the out-of-box config.
jphickey
added
the
CCB:Ready
astrogeco
approved these changes
Jan 13, 2022
Contributor
astrogeco
left a comment
astrogeco
left a comment
There was a problem hiding this comment.
Compiled with bundle and resolved errors with default table
astrogeco
removed
the
CCB:Ready
Contributor
|
CCB:2022-01-19 APPROVED |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Removes the throttle sem name from the example configuration table. Unless the user provides another app/library to create this sem, this configuration will not load. With this sem removed then CF should at least be able to start up.
Fixes #178
Testing performed
Build CF
Expected behavior changes
Example config will not attempt to use a throttle sem.
System(s) tested on
Ubuntu 21.10
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.