Fix #195, Stack smashing in CF_Chunk unit test#196
Merged
Conversation
skliper
added
the
CCB:Ready
jphickey
approved these changes
Feb 10, 2022
3 tasks
astrogeco
reviewed
Feb 11, 2022
|
|
||
| /* Arrange for CF_Chunks_CombineNext to return 0 and CF_Chunks_CombinePrevious to return 0 */ | ||
| CF_ChunkIdx_t dummy_chunks_count = 10; /* 10 for dummy_chunks_count is arbitrary, chosen for speed */ | ||
| CF_ChunkIdx_t dummy_chunks_count; |
Contributor
There was a problem hiding this comment.
Would we get an uninitialized variable warning from static analysis here?
Author
There was a problem hiding this comment.
No, because it's set on line 1468 before use.
astrogeco
added
CCB:Approved
and removed
CCB:Ready
Contributor
|
CCB:2022-02-16 APPROVED |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Testing performed
Built/ran 32 bit unit tests
Expected behavior changes
No longer stack smashing in UT
System(s) tested on
Additional context
None
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC