Skip to content

Fix #214, Resolve buffer overflow in CF_Chunks_InsertChunk unit test#240

Merged
astrogeco merged 1 commit intonasa:mainfrom
skliper:fix214-ut_chunkinsert_failure
May 18, 2022
Merged

Fix #214, Resolve buffer overflow in CF_Chunks_InsertChunk unit test#240
astrogeco merged 1 commit intonasa:mainfrom
skliper:fix214-ut_chunkinsert_failure

Conversation

@skliper
Copy link
Copy Markdown

@skliper skliper commented May 11, 2022

Checklist (Please check before submitting)

Describe the contribution

Rewrites problematic CF_Chunk_InsertChunk tests that occasionally had a buffer overflow due to random number use.

Testing performed
Build and ran unit tests, confirmed passing. Also confirmed no loss in coverage.

Expected behavior changes
Just fixes random unit test failures on a 32 bit system.

System(s) tested on

  • Hardware: i5/wsl
  • OS: Ubuntu 18.04
  • Versions: Bundle main + this commit (and app addition)

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label May 11, 2022
@skliper skliper added this to the Draco milestone May 11, 2022
@skliper skliper force-pushed the fix214-ut_chunkinsert_failure branch from c0b7f5b to cd3804a Compare May 11, 2022 19:14
@chillfig chillfig removed the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label May 18, 2022
@skliper
Copy link
Copy Markdown
Author

skliper commented May 18, 2022

@chillfig - what's the status on this PR? If not CCB:Ready is it CCB:Approved?

@chillfig
Copy link
Copy Markdown
Contributor

@chillfig - what's the status on this PR? If not CCB:Ready is it CCB:Approved?

The status is still CCB:Ready. I removed the label when I added this PR to the CCB agenda: https://github.com/nasa/cFS/wiki/CCB:-2022.05.18
In the future I will remove the CCB:Ready label after the cFS Community CCB meeting instead of before.

@astrogeco
Copy link
Copy Markdown
Contributor

CCB:2022-05-18 APPROVED

@astrogeco astrogeco merged commit 893aa30 into nasa:main May 18, 2022
@skliper skliper deleted the fix214-ut_chunkinsert_failure branch June 10, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test_CF_Chunks_InsertChunk_PutGiven_chunk_IntoSome_chunks occasionally fails on 32 bit system

3 participants