Fix #117 #155, Command handling updates#272
Conversation
There was a problem hiding this comment.
Found 24 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Found 24 potential problems in the proposed changes. Check the Files changed tab for more details.
|
I think if you change the commits to "Fix #117, ..." they should pass. |
There was a problem hiding this comment.
Found 24 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Found 24 potential problems in the proposed changes. Check the Files changed tab for more details.
4d9aea6 to
dca163b
Compare
|
CCB 7/13/2022: Actions: Remove CmdConds and create ticket for Accept and Reject. |
|
Recommend updating title and commit message to something like "Fix #117 #155, validated commands send an info event message and remove CF_CmdCond"... or you could break it into a short and long description like: |
Checklist (Please check before submitting)
Describe the contribution
A clear and concise description of what the contribution is.
Fix #117, an information event message is sent if a command is successful
Fix #155, Remove
CF_CmdCon()Testing performed
Ran unit tests
Expected behavior changes
System(s) tested on
Contributor Info - All information REQUIRED for consideration of pull request
Haven Carlson - NASA