-
Notifications
You must be signed in to change notification settings - Fork 33
Open
Description
Checklist
- I reviewed the Contributing Guide.
- I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.
Describe the bug
There are a couple of minor sections of dead/unnecessary code in CS.
Code snips
-
bufptrcannot beNULL(this is guaranteed byCFE_SB_ReceiveBufferif the return value isCFE_SUCCESS):
Lines 86 to 91 in f958cc0
Result = CFE_SB_ReceiveBuffer(&BufPtr, CS_AppData.CmdPipe, CS_WAKEUP_TIMEOUT); /* Performance Log (start time counter) */ CFE_ES_PerfLogEntry(CS_APPMAIN_PERF_ID); if ((Result == CFE_SUCCESS) && (BufPtr != NULL)) -
Apparently code was removed that set the run status to
CFE_ES_RunStatus_SYS_EXCEPTION, but this check was left in:
Line 119 in f958cc0
if (CS_AppData.RunStatus == CFE_ES_RunStatus_APP_ERROR || CS_AppData.RunStatus == CFE_ES_RunStatus_SYS_EXCEPTION)
Expected behavior
Remove dead code to reduce unnecessary clutter.
Reporter Info
Avi Weiss @thnkslprpt
Metadata
Metadata
Assignees
Labels
No labels