Skip to content

Fix #99, Fill in Name variable to avoid being used uninitialized #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix #99, Fill in Name variable to avoid being used uninitialized #100

wants to merge 1 commit into from

Conversation

@thnkslprpt
Copy link
Contributor

@thnkslprpt thnkslprpt commented Nov 30, 2024 •
edited
Loading

Checklist

Describe the contribution

Minor changes:

  • Formatting applied to remove incorrect indentation in the files being edited
  • Baseline variable in CS_ReportBaselineAppCmd, CS_ReportBaselineEntryIDEepromCmd, CS_ReportBaselineEntryIDMemoryCmd and CS_ReportBaselineTablesCmd only used once in these functions - simplifies to use the value directly and avoid the extra variable (happy to separate out these changes into a separate PR if more suitable).
    • In CS_ReportBaselineEntryIDEepromCmd & CS_ReportBaselineEntryIDEepromCmd two additional simplifications look reasonable:
      • ResultsEntry can be removed
      • the assignment of CS_STATE_UNDEFINED to State can be done at initialization, simplifying the if/else in the error condition

Testing performed
GitHub CI actions all passing successfully (incl. Build + Run, Unit/Functional Tests etc.).

Expected behavior changes
Name variable will be filled in in all use-cases.
Unnecessary variables are removed, which simplifies the code and eases maintenance/testing.

System(s) tested on
Debian 12 using the current main branch of cFS bundle.

Contributor Info
Avi Weiss   @thnkslprpt

@thnkslprpt thnkslprpt force-pushed the fix-99-fill-in-name-variable-at-top-of-function branch from c4e87dc to 4b79eaf Compare November 30, 2024 10:23
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 30, 2024
View reviewed changes
fsw/src/cs_app_cmds.c
Name[sizeof(Name) - 1] = '\0';

if (CS_GetAppResTblEntryByName(&ResultsEntry, Name))
if (CS_GetAppResTblEntryByName(&ResultsEntry, Name))

Check warning

Code scanning / CodeQL

Side effect in a Boolean expression

This Boolean expression is not side-effect free.
fsw/src/cs_app_cmds.c
CS_AppData.HkPacket.Payload.OneShotInProgress == false)
{
/* make sure the entry is a valid number and is defined in the table */
if (CS_GetAppResTblEntryByName(&ResultsEntry, Name))

Check warning

Code scanning / CodeQL

Side effect in a Boolean expression

This Boolean expression is not side-effect free.
fsw/src/cs_app_cmds.c

CFE_EVS_SendEvent(CS_DISABLE_APP_NAME_INF_EID, CFE_EVS_EventType_INFORMATION,
"Checksumming of app %s is Disabled", Name);
if (CS_GetAppResTblEntryByName(&ResultsEntry, Name))

Check warning

Code scanning / CodeQL

Side effect in a Boolean expression

This Boolean expression is not side-effect free.
fsw/src/cs_app_cmds.c
"Checksumming of app %s is Disabled", Name);

CS_AppData.HkPacket.Payload.CmdCounter++;
if (CS_GetAppDefTblEntryByName(&DefinitionEntry, Name))

Check warning

Code scanning / CodeQL

Side effect in a Boolean expression

This Boolean expression is not side-effect free.
fsw/src/cs_app_cmds.c

CFE_EVS_SendEvent(CS_ENABLE_APP_NAME_INF_EID, CFE_EVS_EventType_INFORMATION,
"Checksumming of app %s is Enabled", Name);
if (CS_GetAppResTblEntryByName(&ResultsEntry, Name))

Check warning

Code scanning / CodeQL

Side effect in a Boolean expression

This Boolean expression is not side-effect free.
fsw/src/cs_table_cmds.c
CS_AppData.HkPacket.Payload.OneShotInProgress == false)
{
/* make sure the entry is a valid number and is defined in the table */
if (CS_GetTableResTblEntryByName(&ResultsEntry, Name))

Check warning

Code scanning / CodeQL

Side effect in a Boolean expression

This Boolean expression is not side-effect free.
fsw/src/cs_table_cmds.c

CFE_EVS_SendEvent(CS_DISABLE_TABLES_NAME_INF_EID, CFE_EVS_EventType_INFORMATION,
"Checksumming of table %s is Disabled", Name);
if (CS_GetTableResTblEntryByName(&ResultsEntry, Name))

Check warning

Code scanning / CodeQL

Side effect in a Boolean expression

This Boolean expression is not side-effect free.
fsw/src/cs_table_cmds.c
"Checksumming of table %s is Disabled", Name);

CS_AppData.HkPacket.Payload.CmdCounter++;
if (CS_GetTableDefTblEntryByName(&DefinitionEntry, Name))

Check warning

Code scanning / CodeQL

Side effect in a Boolean expression

This Boolean expression is not side-effect free.
fsw/src/cs_table_cmds.c

CFE_EVS_SendEvent(CS_ENABLE_TABLES_NAME_INF_EID, CFE_EVS_EventType_INFORMATION,
"Checksumming of table %s is Enabled", Name);
if (CS_GetTableResTblEntryByName(&ResultsEntry, Name))

Check warning

Code scanning / CodeQL

Side effect in a Boolean expression

This Boolean expression is not side-effect free.
fsw/src/cs_table_cmds.c
"Checksumming of table %s is Enabled", Name);

CS_AppData.HkPacket.Payload.CmdCounter++;
if (CS_GetTableDefTblEntryByName(&DefinitionEntry, Name))

Check warning

Code scanning / CodeQL

Side effect in a Boolean expression

This Boolean expression is not side-effect free.
@thnkslprpt thnkslprpt force-pushed the fix-99-fill-in-name-variable-at-top-of-function branch from 4b79eaf to 6f88718 Compare November 30, 2024 13:16
@thnkslprpt thnkslprpt force-pushed the fix-99-fill-in-name-variable-at-top-of-function branch from 6f88718 to 951d776 Compare November 30, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Name variable used in events before being filled in

1 participant

@thnkslprpt