Skip to content

Fix #46, Remove unnecessary parentheses around return values. #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2022
Merged

Fix #46, Remove unnecessary parentheses around return values. #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions fsw/src/cs_app.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ int32 CS_AppInit(void)
CFE_EVS_SendEvent(CS_INIT_INF_EID, CFE_EVS_EventType_INFORMATION, "CS Initialized. Version %d.%d.%d.%d",
CS_MAJOR_VERSION, CS_MINOR_VERSION, CS_REVISION, CS_MISSION_REV);
}
return (Result);
return Result;
} /* End of CS_AppInit () */

/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
Expand Down Expand Up @@ -336,7 +336,7 @@ int32 CS_AppPipe(const CFE_SB_Buffer_t *BufPtr)
break;
}

return (Result);
return Result;
} /* End of CS_AppPipe () */

/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
Expand Down Expand Up @@ -663,7 +663,7 @@ int32 CS_CreateRestoreStatesFromCDS(void)
Result = CFE_SUCCESS;
}

return (Result);
return Result;

} /* End of CS_CreateCDS() */

Expand Down
12 changes: 6 additions & 6 deletions fsw/src/cs_table_processing.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ int32 CS_ValidateEepromChecksumDefinitionTable(void *TblPtr)
"CS Eeprom Table verification results: good = %d, bad = %d, unused = %d", (int)GoodCount,
(int)BadCount, (int)EmptyCount);

return (Result);
return Result;
} /* CS_ValidateEEPROMCheckSumDefinitionTable */

/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
Expand Down Expand Up @@ -201,7 +201,7 @@ int32 CS_ValidateMemoryChecksumDefinitionTable(void *TblPtr)
"CS Memory Table verification results: good = %d, bad = %d, unused = %d", (int)GoodCount,
(int)BadCount, (int)EmptyCount);

return (Result);
return Result;
} /* CS_ValidateMemoryCheckSumDefinitionTable */

/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
Expand Down Expand Up @@ -317,7 +317,7 @@ int32 CS_ValidateTablesChecksumDefinitionTable(void *TblPtr)
"CS Tables Table verification results: good = %d, bad = %d, unused = %d", (int)GoodCount,
(int)BadCount, (int)EmptyCount);

return (Result);
return Result;
} /* CS_ValidateTablesCheckSumDefinitionTable */

/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
Expand Down Expand Up @@ -432,7 +432,7 @@ int32 CS_ValidateAppChecksumDefinitionTable(void *TblPtr)
"CS Apps Table verification results: good = %d, bad = %d, unused = %d", (int)GoodCount,
(int)BadCount, (int)EmptyCount);

return (Result);
return Result;
} /* CS_ValidateAppCheckSumDefinitionTable */

/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
Expand Down Expand Up @@ -940,7 +940,7 @@ int32 CS_TableInit(CFE_TBL_Handle_t *DefinitionTableHandle, CFE_TBL_Handle_t *Re
break;
}
}
return (Result);
return Result;

} /* end of CS_CheckSum_Definition_Table_Init () */

Expand Down Expand Up @@ -1052,7 +1052,7 @@ int32 CS_HandleTableUpdate(void *DefinitionTblPtr, void *ResultsTblPtr, CFE_TBL_
(unsigned int)ManageResult2, (unsigned int)GetResult2, TableType);
}
}
return (Result);
return Result;
} /* end CS_HandleTableUpdate */

/************************/
Expand Down
2 changes: 1 addition & 1 deletion fsw/src/cs_utils.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,7 +479,7 @@ bool CS_VerifyCmdLength(const CFE_MSG_Message_t *msg, size_t ExpectedLength)
Result = false;
CS_AppData.HkPacket.CmdErrCounter++;
}
return (Result);
return Result;
} /* End of CS_VerifyCmdLength */

/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
Expand Down