Merged
Conversation
added 2 commits
November 28, 2018 08:47
For very small strains (even smaller plastic strains) the cubed stress erm in the denominator of many newton raphson terms becomes very small below machine precision (NaN). To resolve this, if this condition is sensed zero incremental plastic strain is predicted
purposes. Removed them.
aFrankLion
requested changes
Nov 28, 2018
Member
aFrankLion
left a comment
aFrankLion
left a comment
There was a problem hiding this comment.
Changes look good. Please review the comments and logger statements throughout before we merge into the dev branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressed issue of infinite loops at small strains (became apparent during coupon level verification of OAT)