Skip to content

[nasa/cryptolib#431] Removed max frame size check, restored UT frame …#432

Merged
Donnie-Ice merged 1 commit intodevfrom
431-remove-tc-len_ingest-vs-max_frame_size-check
Mar 25, 2025
Merged

[nasa/cryptolib#431] Removed max frame size check, restored UT frame …#432
Donnie-Ice merged 1 commit intodevfrom
431-remove-tc-len_ingest-vs-max_frame_size-check

Conversation

@Donnie-Ice
Copy link
Collaborator

@Donnie-Ice Donnie-Ice commented Mar 20, 2025

…sizes to 1024

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  • Does your submission pass tests?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?

How do you test these changes?

The TC_Apply/Process UTs automatically test this. Required changes due to CCSDS TC Spec.

@Donnie-Ice Donnie-Ice self-assigned this Mar 20, 2025
@Donnie-Ice Donnie-Ice linked an issue Mar 20, 2025 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.73%. Comparing base (14ee573) to head (bef4644).
Report is 86 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #432      +/-   ##
==========================================
- Coverage   75.97%   75.73%   -0.24%     
==========================================
  Files          81       81              
  Lines       22263    22742     +479     
  Branches     1807     1854      +47     
==========================================
+ Hits        16914    17224     +310     
- Misses       4707     4841     +134     
- Partials      642      677      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dccutrig dccutrig self-requested a review March 25, 2025 21:02
@Donnie-Ice Donnie-Ice merged commit 01b7402 into dev Mar 25, 2025
12 checks passed
@Donnie-Ice Donnie-Ice deleted the 431-remove-tc-len_ingest-vs-max_frame_size-check branch March 25, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove TC len_ingest vs max_frame_size check

4 participants

Comments